recovery: make `TraceLookupMaps` private
tmplt opened this issue · comments
Because of how the lookup maps were generated before the recovery refactor, TraceMetadata is still built from a pre-existing TraceLookupMaps. The only case when this is handy is for --resolve-only. For all other cases the TraceLookupMaps is created just to create a TraceMetadata. Preferably this intermediate structure should not be required.
I've found no way to replace the explicit construction of TraceLookupMaps for --resolve-only. The current requirement for an intermediate structure is not that bad: its only done once in trace/replay.