rstudio / rstudio-docker-products

Docker images for RStudio Professional Products

Home Page:https://hub.docker.com/u/rstudio

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`r-session-complete` misinterprets text files as binary and cannot open preview in IDE

kmasiello opened this issue · comments

Workbench containers running purely from rstudio/r-session-complete are unable to open text files that don't have an extension, e.g., DESCRIPTION, NAMESPACE, and renv.lock in the RStudio IDE. Error message is pasted below:

"file is binary rather than text so cannot be opened by the source editor"
image

Confirmed that the utility file does not exist within the container. After sudo apt-get install file the files will open in the editor. The file utility should be added to r-session-complete so the IDE experience does not ship broken.

Confirmed this behavior in:
jammy-2022.12.0
bionic-2022.12.0
centos7-2022.12.0

@colearendt I can make a PR if this sounds good to you.

Sounds great! Please do! May be worth adding a test as well
https://github.com/rstudio/rstudio-docker-products/blob/main/r-session-complete/test/goss.yaml

Would look like:

package:
  file:
    installed: true

Might want to do the same for Workbench too, just to be safe and make sure we never miss it. We should also probably pass this requirement upstream... if the product requires it to function, I suspect it should declare the dependency in its installer (or fail more gracefully)