rsocket / rsocket-js

JavaScript implementation of RSocket

Home Page:https://github.com/rsocket/rsocket-js

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Calls to `fbjs/lib/warning` result in an exception in `FlowableProcessor`

viglucci opened this issue · comments

Any call to fbjs/lib/warning in FlowableProcessor results in an exception.

Error: `warning(condition, format, ...args)` requires a warning message argument
    at warning (E:\dev\rsocket-js-examples\examples\websocket-server-request-channel\node_modules\fbjs\lib\warning.js:43:11)
    at FlowableProcessor.onError (E:\dev\rsocket-js-examples\examples\websocket-server-request-channel\node_modules\rsocket-flowable\build\FlowableProcessor.js:44:28)
    at E:\dev\rsocket-js-examples\examples\websocket-server-request-channel\node_modules\rsocket-core\build\RSocketMachine.js:230:20
    at Map.forEach (<anonymous>)
    at Object.onError (E:\dev\rsocket-js-examples\examples\websocket-server-request-channel\node_modules\rsocket-core\build\RSocketMachine.js:229:25)
    at SubscriberSwapper.onError (E:\dev\rsocket-js-examples\examples\websocket-server-request-channel\node_modules\rsocket-core\build\RSocketServer.js:259:42)
    at FlowableSubscriber.onError (E:\dev\rsocket-js-examples\examples\websocket-server-request-channel\node_modules\rsocket-flowable\build\Flowable.js:231:50)
    at ReassemblySubscriber.onError (E:\dev\rsocket-js-examples\examples\websocket-server-request-channel\node_modules\rsocket-core\build\ReassemblyDuplexConnection.js:84:18)
    at WebSocket.onSocketClosed (E:\dev\rsocket-js-examples\examples\websocket-server-request-channel\node_modules\rsocket-websocket-server\build\RSocketWebSocketServer.js:146:20)
    at WebSocket.emit (events.js:327:22)

Expected Behavior

js/lib/warning should be invoked with the property arguments so an exception is not thrown.

Actual Behavior

js/lib/warning is invoked with an improper number of arguments, resulting in an exception.

Steps to Reproduce

Create a FlowableProcessor and invoke any of the onNext, onError, etc. methods while _sink is null (such as prior to calling subscribe).

const processor = new FlowableProcessor();
processor.onNext(); // <-- exception is thrown from `warning` call.

Your Environment

  • RSocket version(s) used: 0.0.25
  • Other relevant libraries versions (eg. netty, ...): fbjs: 3.0.0
  • Platform (eg. JVM version (javar -version) or Node version (node --version)): v14.16.1