rsmbl / Resemble.js

Image analysis and comparison

Home Page:http://rsmbl.github.io/Resemble.js/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

canvas-prebuild deprecated

dcharbonnier opened this issue · comments

NOTE: the canvas-prebuilt package is deprecated. As of version 2, canvas itself bundles prebuilt versions from this repo. Install by running

npm install --save canvas
…and use canvas as usual.

I've been looking into this but it appears that the prebuilt packages for Canvas for Windows 10 on Node 10 & 11 cause the following error, at least for me

    TypeError: Cannot read property 'call' of undefined
      at setSource (node_modules/canvas/lib/image.js:102:14)
      at Image.set (node_modules/canvas/lib/image.js:68:7)
      at loadImageData (resemble.js:270:33)

Struggling to find the time to understand the issue, seems to relate to Automattic/node-canvas#1294
Automattic/node-canvas#1247

Hi @jamescryer, can you please take another look at this? Automattic/node-canvas#1294 has been closed and Automattic/node-canvas#1247 has been merged and hopefully fixed the problem you ran into.

I don't have a Windows machine to test it myself but I would much appreciate an update as the current version of resemblejs does not work anymore on a Mac when using Node v11.

Many thanks in advance.

I've just pushed a v3 branch https://github.com/HuddleEng/Resemble.js/tree/v3. Unfortunately it doesn't work on Ubuntu (Docker Node:11 image), and intermittently breaks on Windows 10 - not ready for general release.

Thanks for the update. Is there anything I could do to help you? Or do you think it is just a matter of waiting for node-canvas to stabilize on Node v11?