Headless NDI output resolution
me-vlad opened this issue · comments
Headless NDI output creates a NDI stream with wrong resolution when frameless output is disabled (please see screenshots with a Vingester main window and NDI monitor).
When frameless output is enabled - NDI output resolution is OK.
Vingester version: 2.2.6
OS: Windows 10 Pro x86_64 21H1
I've tried exactly your test under both macOS and Windows and it worked as expected:
Can you try to change your monitor resolution to 1920x1080?
When I set Vingester output size to 1280x720 on a fullhd notebook NDI stream resolution is 1280x720, but when I set output to 1080p - NDI resolution is 1482x834
I've tried it on a 1920x1080 pixel display. But it made no difference: it worked as expected:
Can you export your exact configuration and show me the YAML file, please? Perhaps there is something still different between our configurations...
Can you export your exact configuration and show me the YAML file, please? Perhaps there is something still different between our configurations...
%YAML 1.2
##
## Vingester Configuration
## Version: Vingester 2.2.6
## Date: 2021-06-20 20:24
##
---
- BrowserTitle: "Vingester-Test"
BrowserInfo: "Vingester Test Page"
BrowserWidth: 1920
BrowserHeight: 1080
BrowserColor: "transparent"
BrowserZoom: 1
BrowserTrust: false
BrowserNodeAPI: false
BrowserOBSDOM: false
BrowserPersist: false
InputURL: "https://vingester.app/test/"
PatchDelay: 0
PatchFrame: ""
PatchStyleType: "inline"
PatchStyleCode: ""
PatchScriptType: "inline"
PatchScriptCode: ""
Output1Enabled: false
Output1VideoPositionX: 0
Output1VideoPositionY: 0
Output1VideoDisplay: 0
Output1VideoPinTop: false
Output1AudioDevice: ""
Output2Enabled: true
Output2VideoFrameRate: 30
Output2VideoAdaptive: false
Output2VideoDelay: 0
Output2AudioSampleRate: 48000
Output2AudioChannels: 2
Output2AudioDelay: 0
Output2SinkNDIEnabled: true
Output2SinkFFmpegEnabled: false
Output2SinkFFmpegMode: "vbr"
Output2SinkFFmpegFormat: "matroska"
Output2SinkFFmpegOptions: "vingester-test.mkv"
PreviewEnabled: false
ConsoleEnabled: false
DevToolsEnabled: false
Collapsed: falseI've tried it on a 1920x1080 pixel display. But it made no difference: it worked as expected:
It is a dual monitor system? Take a look to NDI monitor windows title.
It's a system with three monitors. One 4K in landscape mode, one 4K in portrait mode and a 1080p in landscape mode.
In the meantime, I've released 2.2.7 so we are at least on the same Electron version 13.1.2. Please check it again with Vingester 2.2.7, just to be sure the difference does not come of different software between us...
I've tried out your particular configuration by importing it into a Vingester 2.2.7 and I got a correct 1920x1080 information displayed in the NDI display.
The NDI monitor title is interesting, ideed! Looks like the Web Contents sees 1920x1080 pixels, but the resulting NDI stream is more because I'm on a display with 150% scale factor. Perhaps your scale factor is also the problem?
Ok, I don't know why the Web Contents sees different sizes for you and always the expected sizes for me, but we have at least a bug discovered: with "frameless" mode enabled, the NDI output is 1080p for me. When "frameless" mode is disabled, the NDI output is scaled up by 150% (which for me is actually the "frameless" mode scale factor). I've to check the code now, as this is certainly a bug.
yes, it looks like resolution/scaling related issue.
If I change monitor scale from 125% to 100% NDI stream resolution changes from 1482x834 to 1867x1050
Ok, seems like Electron uses the scale factor of the primary display if an offscreen browser window (which is used for "headless" mode) is used. I've tried to fix it for the forthcoming Vingester 2.2.8
Ok, 2.2.8 is out. Can you recheck your situation with this new version which hopefully also fixes the problems for you?
Ok, 2.2.8 is out. Can you recheck your situation with this new version which hopefully also fixes the problems for you?
Just updated Vingester to 2.2.8, NDI stream resolution looks OK