rriverak / vscode-gitlab-explorer

VSCode extension for working with GitLab Project Items, supporting both GitLab.com and custom GitLab Servers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Feature: hide the Personal Access Token

felipe1982 opened this issue · comments

Feature Request

Provide the ability to give PAT, but not show it

Other

This extension https://marketplace.visualstudio.com/items?itemName=fatihacet.gitlab-workflow Allows the user to press Ctrl + Shift + p and enter the PAT in there.
Repo: https://gitlab.com/fatihacet/gitlab-vscode-extension

Environment

Windows 10
Latest VS Code c.2018-08-08

Hey,
thank you for your interest in this extension.

Provide the ability to give PAT, but not show it

You're right, this is actually a security problem.
The GitLab Explorer Extension use a Memento Class in the ExtensionContext Scope to store this Value.

This sounds a bit hacky to me ;)
But, I will take a look at this solution.

I hope that it is not snake oil and the Memento (in globalState Context) is safe enough.

Here some more Informations ;)
microsoft/vscode#15414