rpm-software-management / rpmlint

Tool for checking common errors in rpm packages

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Warn if binary symlink is pointing to /usr/share/ and target is a script

darix opened this issue · comments

it seems RPM then does not follow the symlink to find the shebang line.

see https://build.opensuse.org/request/show/1116460 -> https://bugzilla.opensuse.org/show_bug.cgi?id=1216028

What do you think it should be the rpmlint warning? If it detects a link in /usr/bin and the destination has a shebang the message could be something like:

W: link-to-binary-with-shebang /usr/bin/gnome-characters is a link to a script with shebang, rpm won't be able to detect the dependency automatically.

well that would be one option. the other would be

W: link-to-binary-with-shebang /usr/bin/gnome-characters is a link to a script but missing requires for /usr/bin/gjs-shell

I mean we might also want to try to find out why rpm ignores symlinks to /usr/share when parsing shebang lines. but that is for a different bug.

the nice bit for checking if a requires for the shebang line exists ... if rpm starts parsing files in /usr/share again it will become satisfied as well and rpmlint guides packager in the mean time.

Thank you for the quick fix!