Giters

rpm-software-management / rpmlint

Tool for checking common errors in rpm packages

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"communication not allowed" error in the wrong format and has no explanation

farchord opened this issue · comments

commented

Building a package for Fedora gives the following error:

kde-inotify-survey.x86_64: E: communication not allowed /usr/share/dbus-1/system.d/org.kde.kded.inotify.conf

The error message is inconsistent with normal rpmlint errors (format-wise) and has no explanation.

Thanks!

commented

Confirmed, you are right. I'm going to prepare a patch. When it comes to the explanation, I will likely need a help from @mgerstner. Am I right that it tells that there's no D-Bus rule that would allow a sending?

commented

I'm going to change the check name in #1009 and I'm going to leave this issue for future improvement of the missing description text.

commented

Yes it means that no one is allowed to talk to the service in question. Except root maybe?

This check is not part of the security related restrictions that we redesigned, it's general quality assurance. Adding a descriptive long description can be considered.

commented

Adding a descriptive long description can be considered.

Can you (or anybody familiar enough with D-Bus) do that, please?

commented

Not sure if it helps, but this is the content of the file in question that triggered that error:

<!DOCTYPE busconfig PUBLIC
 "-//freedesktop//DTD D-BUS Bus Configuration 1.0//EN"
 "http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd">
<busconfig>
 
  <!-- Only user root can own the foo helper -->
  <policy user="root">
    <allow own="org.kde.kded.inotify"/>
  </policy>
 
</busconfig>
commented

It turns out there already was a description for this situation, only the error name was/is still not matching. Not sure how that happened, probably during the migration from the old rpmlint-checks repository.