rpki-client / rpki-client-portable

Portability shim for OpenBSD's rpki-client

Home Page:https://rpki-client.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

build: configure vs autogen.sh

reschke opened this issue · comments

The instructions in README.md say:

Building

$ ./configure
$ make

but "configure" is neither in git nor in the release tar file (tried: https://github.com/rpki-client/rpki-client-portable/archive/refs/tags/7.1.tar.gz)

Ah, the release tarball is https://cdn.openbsd.org/pub/OpenBSD/rpki-client/rpki-client-7.1.tar.gz

We might need to look into disabling the 'github generated tarball' as that is not a PGP/Signify signed release artefact (and apparently incomplete)

Indeed, thanks!

We might need to look into disabling the 'github generated tarball' as that is not a PGP/Signify signed release artefact (and apparently incomplete)

We could try to upload the official release tarball plus signatures using the GitHub API additionally, I guess (not sure if we can disable at GitHub the ability to grab a .tar.gz or .zip from a tag, commit, branch etc. when reading https://github.community/t/disable-tarball/139966).

Edit: https://docs.github.com/en/rest/reference/repos#upload-a-release-asset could be what I mean.

Instead of adding more to github I think we should point users to rpki-client.org and the official releases.
This is just a meta-repository that allows us to create the portable releases. It is primarily useful for us maintainers. If you want to install rpki-client on a system you should use the official tarballs instead.

I guess the confusion stems from our git tags carrying names similar to what a tarball filename would be, and tarballs are of course generated from tags as a convenience service. Unsure how to clarify this...

Suggestions welcome, this probably is a documentation issue 2190b0b

Is it possible to have github show the INSTALL file instead of README.md? In that case it would be possible to better explain how to use this repository.

Adjusted the documentation a bit more.