build problem with 6.8p0

[John Kristoff]

Hello again,

In an attempt to upgrade from 6.7p1 I went through essentially the same build process, but ran into problems. Perhaps the most severe issue is what appears to be a requirement for functions only found in LibreSSL, which are not typically found on most Linux distributions by default. Is LibreSSL expected to be a requirement now?

rpki-client-portable-6.8p$ make
Making all in include
make[1]: Entering directory '/home/jtk/dl/rpki-client-portable-6.8p0/include'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/jtk/dl/rpki-client-portable-6.8p0/include'
Making all in compat
make[1]: Entering directory '/home/jtk/dl/rpki-client-portable-6.8p0/compat'
  CC       recallocarray.lo
recallocarray.c: In function ‘recallocarray’:
recallocarray.c:60:28: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} a
nd ‘int’ [-Wsign-compare]
   if (d < oldsize / 2 && d < getpagesize()) {
                            ^
  CC       strlcat.lo
  CC       strlcpy.lo
  CC       strtonum.lo
  CCLD     libcompat.la
ar: `u' modifier ignored since `D' is the default (see `U')
  CCLD     libcompatnoopt.la
ar: `u' modifier ignored since `D' is the default (see `U')
make[1]: Leaving directory '/home/jtk/dl/rpki-client-portable-6.8p0/compat'
Making all in src
make[1]: Entering directory '/home/jtk/dl/rpki-client-portable-6.8p0/src'
  CC       rpki_client-as.o
  CC       rpki_client-cert.o
  CC       rpki_client-cms.o
  CC       rpki_client-crl.o
  CC       rpki_client-io.o
  CC       rpki_client-ip.o
  CC       rpki_client-log.o
  CC       rpki_client-main.o
main.c: In function ‘main’:
main.c:1669:7: warning: ‘rsyncpid’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (waitpid(rsyncpid, &st, 0) == -1)
       ^~~~~~~~~~~~~~~~~~~~~~~~~
  CC       rpki_client-mft.o
mft.c: In function ‘generalizedtime_to_tm’:
mft.c:69:9: error: implicit declaration of function ‘ASN1_time_parse’; did you mean ‘ASN1_parse’? [-Werror=implicit-function-declaration]
  return ASN1_time_parse(data, len, tm, V_ASN1_GENERALIZEDTIME) ==
         ^~~~~~~~~~~~~~~
         ASN1_parse
mft.c: In function ‘check_validity’:
mft.c:99:6: error: implicit declaration of function ‘ASN1_time_tm_cmp’; did you mean ‘ASN1_item_dup’? [-Werror=implicit-function-declaration]
  if (ASN1_time_tm_cmp(&tm_until, &tm_from) < 0) {
      ^~~~~~~~~~~~~~~~
      ASN1_item_dup
cc1: some warnings being treated as errors
make[1]: *** [Makefile:648: rpki_client-mft.o] Error 1
make[1]: Leaving directory '/home/jtk/dl/rpki-client-portable-6.8p0/src'
make: *** [Makefile:454: all-recursive] Error 1

[Claudio Jeker]

You are building against the OPENBSD_6_8 branch and not what actually is 6.8p0.
The OPENBSD_6_8 branch has bits in it for 6.8p1 but is missing a few cherry picks from master.
This should be fixed soon. Until then use the official tarball from https://www.rpki-client.org/portable.html
or use the 6.8p0 tags for both git trees.

[John Kristoff]

D'oh, I should have noticed that. Thanks Claudio, I grabbed a tarball from one of the mirrors and that works much better. :-)