Steps of duration "0" should pause, or default duration should be empty string
sixohsix opened this issue · comments
Is your feature request related to a problem? Please describe.
I created a recipe with some steps I expected to pause, but they transitioned through instantly instead. I discovered that the duration was set to 0, but this is different than an empty-string duration, which triggers a pause. I didn't expect this. 0 is the default duration value, which is super weird.
Describe the solution you'd like
0 duration should trigger a step pause. There is no meaning in a 0 second step otherwise.
Describe alternatives you've considered
You could set the default value for duration to the empty string to avoid changing the semantics of the field (in case some weirdo still demands a 0 second step as a possibility).
You could have an additional button for "pause after this step". I think another feature request mentioned this, but I suspect this might be more expensive to implement.
Additional context
Very cool app! I'm tempted to try and implement my request with a PR but Android development terrifies me.
Hi @sixohsix sorry for such late reply.
While I agree that 0/empty time for a step is not great from UX perspective, I need that separation for my own satisfaction.
I use 0 time steps for stuff like "Add coffee" as I launch the app only after grinding up the coffee and preparing the brewer, but I still need coffee weight for ratio, and stats. And I require empty time steps that stop for stuff like Iced V60 where I require undefined time to add ice to the brewer.
I agree that it would be better to add a switch to control this behavior, I'm afraid of overcomplicating the UI for such niche use case. I guess it's another thing to add onto the pile of stuff I need to redesign when I finally have time to sit down for a longer coding session.
Sure, I understand why you need both. Only suggestion I have is, if it's possible to put some descriptive text in the time box when it's empty, you could put "pause on this step" there so that it's more clear that the box has a meaning when empty.
And also default to empty input instead of 0 so that I see that text.
But anyway it's a great app and I can live with it as it is. Thanks for the reply.
In the newest version (that's on GitHub releases, and soon on F-Droid) I've changed the behavior to be empty by default. I have had issues with the Google Play Store release for months now so updates there will take some more time.
As for the explainer, there is a ℹ️ button inside Duration input explaining what 0 and Empty state do to the behavior, but maybe you are right that it needs to be better communicated. I'll think about it 😅