rotdrop / nextcloud-app-files-archive

Archive inspection and extraction as Nextcloud app.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rar + password producing UNREADABLE files

sergeng opened this issue · comments

Describe the bug
when i mount a rar achive with password and provide the correct password in the Archive tab
the mount point is created with the files inside BUT they are unreadable
I assume the rar password decryption is buggy
zip archive password decryption works flawless

Configration (please complete the following information):

OS: ubuntu 20.04
Version of library:
To Reproduce
Upload a rar file with password
type the password in the archive tab
mount the rar file via context menu

Expected behavior
should decrypt and mount with password given

Sorry for not coming back to this earlier. Is it possible for you to provide a rar-archive which does not work s.t. we have something to work on? Best something very small but with password protection.

From the support matrix of unified-archive

https://github.com/wapmorgan/UnifiedArchive/blob/master/docs/Drivers.md#full-support-matrix

password protected files should in principle work. I have generated a simplistic rar-archive with the password "foobar" which actually cannot properly extracted. I need to investigate further.

I think that this commit should fix this issue: 734910a

BTW, the problem were not the RAR-archives, the problem was that the app passed the encrypted password to the archive backend when staying on the files view. Later reloading the page should in principle have worked. Anyhow, the passphrase handling was buggy.

May I close this issue? Does it work?