Xacro evaluates commented out code

Question

Xacro evaluates commented out code

alaurenzi opened this issue 2 years ago · comments

After a binary update, I am facing a bug where xacro will evaluate code sections that are commented out.

How to reproduce

Create a minimal xacro file with some commented out statement, save it as text.xacro

<robot xmlns:xacro="http://www.ros.org/wiki/xacro">
<!-- $(find dontexist) -->
</robot>

Run xacro test.xacro
Output:

arturo@arturo-iit-desktop ~/code/xacro_bug $ xacro test.xacro 
resource not found: dontexist
ROS path [0]=/opt/ros/melodic/share/ros
ROS path [1]=/home/arturo/code/robot_ws/src
ROS path [2]=/home/arturo/code/robot_ws/install/share
ROS path [3]=/home/arturo/code/robot_ws/install/lib
ROS path [4]=/opt/ros/melodic/share
ROS path [5]=/opt/xbot/share
ROS path [6]=/opt/xbot/lib
when processing file: test.xacro

Some info about my setup

arturo@arturo-iit-desktop ~/code/xacro_bug $ which xacro
/opt/ros/melodic/bin/xacro

arturo@arturo-iit-desktop ~/code/xacro_bug $ dpkg -S /opt/ros/melodic/bin/xacro
ros-melodic-xacro: /opt/ros/melodic/bin/xacro

arturo@arturo-iit-desktop ~/code/xacro_bug $ apt-cache show ros-melodic-xacro
Package: ros-melodic-xacro
Version: 1.13.15-1bionic.20220120.162849
Architecture: amd64
Maintainer: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
Installed-Size: 172
Depends: ros-melodic-roslaunch
Homepage: http://ros.org/wiki/xacro
Priority: optional
Section: misc
Filename: pool/main/r/ros-melodic-xacro/ros-melodic-xacro_1.13.15-1bionic.20220120.162849_amd64.deb
Size: 48392
SHA256: 94b072fadc0e09c8fb153b9a7bd27c0d85454e034122116556acc334d0012a06
SHA1: ea8747bc28bec20a7d3b380b6c714c3f2dc0d7e9
MD5sum: dc1b6217b004853d052926ee21ef27d2
Description: Xacro (XML Macros) Xacro is an XML macro language.
 With xacro, you can construct shorter and more readable XML files by using macros that expand to larger XML expressions.
Description-md5: 8c0e70c27149552580f6b48bb7d34387

Anything else I might help you with?

G.A. vd. Hoorn · Answer 1 · Tue Feb 01 2022 19:05:36 GMT+0800 (China Standard Time)

Related: #300 (comment).

Robert Haschke · Answer 2 · Tue Feb 01 2022 20:25:05 GMT+0800 (China Standard Time)

Mitigated by a warning (instead of an error) in melodic-devel and noetic-devel.

Caio Amaral · Answer 3 · Thu Feb 10 2022 03:56:51 GMT+0800 (China Standard Time)

I've just faced the same problem. Is there a new release coming with the fix?

Robert Haschke · Answer 4 · Thu Feb 10 2022 15:51:31 GMT+0800 (China Standard Time)

@caioaamaral, of course, a new release is planned. But, I simply didn't have time yet to come back here. Please note, that I am the only active maintainer of this package and I am doing all this work voluntarily in my free time. I hope to find some time over the weekend to cut a new release, but I cannot promise. If you appreciate my work, please consider donating.

Caio Amaral · Answer 5 · Thu Feb 10 2022 20:30:43 GMT+0800 (China Standard Time)

@caioaamaral, of course, a new release is planned.

Good to know, thanks for your effort in maintaining xacro

ros-discourse · Answer 6 · Fri Feb 11 2022 22:01:42 GMT+0800 (China Standard Time)

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/new-packages-for-noetic-2022-02-11/24292/3

ros-discourse · Answer 7 · Sat Feb 12 2022 06:01:19 GMT+0800 (China Standard Time)

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/preparing-for-noetic-sync-2022-02-14/24313/1

Robert Haschke · Answer 8 · Sat Feb 12 2022 22:09:42 GMT+0800 (China Standard Time)

Comment evaluation is opt-in now: #310. New releases are triggered: