ropensci / rfisheries

package for interacting with fisheries databases at openfisheries.org

Home Page:https://docs.ropensci.org/rfisheries

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

API changed, package needs an update asap

karthik opened this issue · comments

This is almost fixed up. Species codes currently don't resolve (but don't fail any tests since there is no data from several species). Andrew is working on this right now.

@CottonRockwood Thanks for alerting us to the problem. If you reinstall the package from a new branch, it should work for countries. We are working to fix the bug with species (but no need to update the package after; it should work automatically once the API end is fixed). Also with the new api you should also be able to request country + species combinations. I'll add that new functionality shortly.

library(devtools)
install_github("ropensci/rfisheries@new_api")

No problem. Looking forward to having the species functionality back up plus the added combination country/species search functionality!

I've tested on my end, and things appear to be back to normal. I'll wait to hear from either Karthik or Cotton and then we can close this issue.

Also, @CottonRockwood a HUUUGE thank you to notifying me of this.

Everything works perfectly for me too. Thanks @andrewjdyck!
I'm going to merge this into master now and push an update to CRAN tomorrow.

@CottonRockwood

library(devtools)
install_github("ropensci/rfisheries")

Give this a go. If all looks good, I'll push to CRAN tomorrow.

Hey gents. Thanks for the quick work fixing things up. Everything works on my end, so I think that its a go.