ronxin / wevi

Word Embedding Visual Inspector

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

bug on firefox - words get multiple vectors

denik opened this issue · comments

Seems to works fine for me on Chrome, but on Firefox, it looks like this (Note George twice):

screen shot 2015-12-06 at 22 59 59

I noticed in the docs, it says there are known issues with FF. Feel free to close this if no plans to support FF.

Yes... that is the very issue I observed in FF. Do you have any idea what is causing this? Might be an easy fix.

Perhaps in this line unique() does not do what the name implies?

https://github.com/ronxin/wevi/blob/master/js/toyw2v.js#L104

vocab = $.unique(vocab).sort()

See http://stackoverflow.com/a/8137873 which suggests sorting first and then calling unique().

@denik Thanks for catching this!