java.lang.IllegalStateException: zip file closed

Question

java.lang.IllegalStateException: zip file closed

nurk opened this issue 5 years ago · comments

When using version 9.12 on kubernetes 1.15 with spring boot 2.2.4 we get following error.
When using version 9.11 we do not have this issue.

Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [x.x.x.SerializedTypeNameResolver]: Factory method 'serializedTypeNameResolver' threw exception; nested exception is java.lang.IllegalStateException: zip file closed
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:185) ~[spring-beans-5.2.3.RELEASE.jar!/:5.2.3.RELEASE]
	at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:651) ~[spring-beans-5.2.3.RELEASE.jar!/:5.2.3.RELEASE]
	... 95 common frames omitted
Caused by: java.lang.IllegalStateException: zip file closed
	at java.base/java.util.zip.ZipFile.ensureOpen(ZipFile.java:915) ~[na:na]
	at java.base/java.util.zip.ZipFile.stream(ZipFile.java:647) ~[na:na]
	at java.base/java.util.zip.ZipFile$1.stream(ZipFile.java:1131) ~[na:na]
	at java.base/java.util.jar.JarFile.stream(JarFile.java:534) ~[na:na]
	at org.reflections.vfs.ZipDir.lambda$getFiles$2(ZipDir.java:21) ~[reflections-0.9.12.jar!/:na]
	at org.reflections.Reflections.scan(Reflections.java:260) ~[reflections-0.9.12.jar!/:na]
	at org.reflections.Reflections.scan(Reflections.java:216) ~[reflections-0.9.12.jar!/:na]
	at org.reflections.Reflections.<init>(Reflections.java:137) ~[reflections-0.9.12.jar!/:na]
	at org.reflections.Reflections.<init>(Reflections.java:182) ~[reflections-0.9.12.jar!/:na]
	at org.reflections.Reflections.<init>(Reflections.java:155) ~[reflections-0.9.12.jar!/:na]
	at x.x.x.serializedTypeNameResolver.getTypesForName(SerializedTypeNameResolver.java:44) ~[integration-axondb-11.369.0.jar!/:11.369.0]
	at x.x.x.serializedTypeNameResolver.<init>(GSerializedTypeNameResolver.java:23) ~[integration-axondb-11.369.0.jar!/:11.369.0]
	at x.x.x.serializedTypeNameResolver(AxonServerSharedConfiguration.java:115) ~[integration-axondb-11.369.0.jar!/:11.369.0]

Our config is as follows:

private Map<String, Class<?>> getTypesForName() {
        Reflections reflections = new Reflections("x.x.x");
        return reflections.getTypesAnnotatedWith(JsonTypeInfo.class).stream()
            .map(clazz -> clazz.getAnnotationsByType(JsonSubTypes.class))
            .flatMap(Arrays::stream)
            .flatMap(annotation -> Arrays.stream(annotation.value()))
            .filter(type -> isValidType(type.value()))
            .collect(toMap(JsonSubTypes.Type::name, JsonSubTypes.Type::value, (name1, name2) -> name1));
    }

"edit"
It runs on adoptOpenJdk 11.0.6_10

Philipp Heuer · Answer 1 · Thu Jan 30 2020 20:44:55 GMT+0800 (China Standard Time)

I just had the same issue with 9.12 in a container with SpringBoot 2.2.4. I'm using OpenJDK11 though, the library only seems to support 8 officially. Running it with 11 on my workstation works though.

gs80140 · Answer 2 · Mon Feb 03 2020 21:49:26 GMT+0800 (China Standard Time)

I have the same issue with 9.12 in springboot

João Vitor Borges · Answer 3 · Thu Feb 06 2020 03:34:05 GMT+0800 (China Standard Time)

I got the same issue when running a packed jar from spring boot, but starting the same application from the source-code with maven spring plugin, run without any related issue

Aouichaoui Youssef · Answer 4 · Sun Feb 09 2020 23:51:30 GMT+0800 (China Standard Time)

take a look at this : sebastianarnold/TeXoo#20 (comment)

zhulei · Answer 5 · Wed Apr 08 2020 12:08:22 GMT+0800 (China Standard Time)

When using the springboot jar, you can rewrite the org.reflections.vfs.zipfile class and implement it with org.springframework.boot.loader.jar.JarFile.

org.springframework.boot spring-boot-loader

bessoft · Answer 6 · Thu May 07 2020 18:53:06 GMT+0800 (China Standard Time)

I have the same issue with 9.12 in springboot

Vlad Poskatcheev · Answer 7 · Sat May 23 2020 07:11:13 GMT+0800 (China Standard Time)

Could this be related to multi threading issue that's been around since 0.9.10 and described in #81? A common "solution" is to downgrade to 0.9.9 until it's fixed. :(

alla-gofman · Answer 8 · Fri Jun 12 2020 02:17:31 GMT+0800 (China Standard Time)

I have the same issue after upgrading to reflections 9.12.
I use spring framework version 5.2.1.RELEASE

Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [com.bmc.cm.command.cm_actuators.ClassFinder]: Factory method 'getClassFinder' threw exception; nested exception is java.lang.IllegalStateException: zip file closed at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:185) at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:640) ... 81 more Caused by: java.lang.IllegalStateException: zip file closed at java.base/java.util.zip.ZipFile.ensureOpen(ZipFile.java:915) at java.base/java.util.zip.ZipFile.stream(ZipFile.java:647) at java.base/java.util.zip.ZipFile$1.stream(ZipFile.java:1131) at java.base/java.util.jar.JarFile.stream(JarFile.java:534) at org.reflections.vfs.ZipDir.lambda$getFiles$2(ZipDir.java:21) at org.reflections.Reflections.scan(Reflections.java:260) at org.reflections.Reflections.scan(Reflections.java:216) at org.reflections.Reflections.<init>(Reflections.java:137) at org.reflections.Reflections.<init>(Reflections.java:182) at org.reflections.Reflections.<init>(Reflections.java:155) ... at org.springframework.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:244) at org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:363) at com.bmc.cm.aft.cfg.AftConfiguration$$EnhancerBySpringCGLIB$$3eca469e.getClassFinder(<generated>) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:154)

Yotam Shtossel · Answer 9 · Thu Jul 16 2020 22:11:02 GMT+0800 (China Standard Time)

#me_too --> downgraded to 0.9.11 as suggested.

Nikola Stanković · Answer 10 · Sat Aug 15 2020 07:12:47 GMT+0800 (China Standard Time)

Facing the same issue ... any updates?

idkw · Answer 11 · Tue Oct 20 2020 22:15:53 GMT+0800 (China Standard Time)

This is still an issue, I also had to downgrade to 0.9.11, is there something we can do to help figure this out ?

Andreas · Answer 12 · Wed Oct 28 2020 20:22:12 GMT+0800 (China Standard Time)

Same issue since Spring Boot upgrade from 2.3.3 to 2.3.4 (spring-boot-starter-parent)

Nigel Jones · Answer 13 · Tue Nov 03 2020 18:40:32 GMT+0800 (China Standard Time)

We've seen the same with egeria (link above) which affects both 2.3.4 and 2.3.5 of spring boot. 2.3.3 is working fine.

We do have a dependency (maven build) on reflections 0.9.12 also used elsewhere.

Nacho Mezzadra · Answer 14 · Fri Nov 13 2020 21:27:16 GMT+0800 (China Standard Time)

This seems to have been fixed now in Spring boot 2.3.6.RELEASE

"java.lang.IllegalStateException: zip file closed" when call JarFileWrapper.stream() of spring-boot-loader #23821

https://github.com/spring-projects/spring-boot/releases/tag/v2.3.6.RELEASE

bmaehr · Answer 15 · Mon Dec 07 2020 21:44:23 GMT+0800 (China Standard Time)

This seems to have been fixed now in Spring boot 2.3.6.RELEASE

"java.lang.IllegalStateException: zip file closed" when call JarFileWrapper.stream() of spring-boot-loader #23821

https://github.com/spring-projects/spring-boot/releases/tag/v2.3.6.RELEASE

As far as I understood spring fixed a similar problem, but not the same. At least I still have the problem with spring-boot 2.4.0 and reflections 0.9.12. Downgrading to 0.9.11 solves it.

tandr · Answer 16 · Sat Jan 30 2021 09:05:00 GMT+0800 (China Standard Time)

0.9.11 has the same error popping up for us randomly (we are not using spring), with exactly same message. Could it be that there is something unfortunate in openjdk 11? We are mixing things built with java 11 and java 8, don't know if this is important.

Lucas Ventura Carro · Answer 17 · Fri Mar 26 2021 02:20:55 GMT+0800 (China Standard Time)

When using the springboot jar, you can rewrite the org.reflections.vfs.zipfile class and implement it with org.springframework.boot.loader.jar.JarFile.

org.springframework.boot spring-boot-loader

I'm trying (after some time digging) but I'm still getting same issue,

Vfs.addDefaultURLTypes(new Vfs.UrlType()
{
    @Override
    public boolean matches(final URL url) throws Exception
    {
        return url.getProtocol().equals("jar") && isInsideBootInf(url);
    }

    private boolean isInsideBootInf(final URL url)
    {
        return url.toExternalForm().matches("^.*\\.jar\\!\\/BOOT-INF\\/lib\\/my-fancy-lib(?:-\\d+\\.\\d+\\.\\d+)?\\.jar\\!\\/$");
    }

    @Override
    public Vfs.Dir createDir(final URL url) throws Exception
    {
        return new ZipDir(new org.springframework.boot.loader.jar.JarFile(Vfs.getFile(url)));
    }
});
final Reflections reflections = new Reflections(baseClassPackage);

idkw · Answer 18 · Wed Jun 23 2021 22:12:03 GMT+0800 (China Standard Time)

Can a 0.9.13 patch version be released to fix this issue ?
Do you need help to make this happen ? What can we do to help ?

Austin Arbor · Answer 19 · Thu Oct 14 2021 00:16:16 GMT+0800 (China Standard Time)

Does this issue still persist in latest 0.10.x releases?

ronmamo · Answer 20 · Wed Oct 27 2021 13:54:43 GMT+0800 (China Standard Time)

as @nachomezzadra mentioned

This seems to have been fixed now in Spring boot 2.3.6.RELEASE

"java.lang.IllegalStateException: zip file closed" when call JarFileWrapper.stream() of spring-boot-loader #23821

https://github.com/spring-projects/spring-boot/releases/tag/v2.3.6.RELEASE

not sure if it worth a workaround (avoid jarFile.stream() introduced in 937c8f3 ZipDir#getFiles) even though it was fixed later in springboot, or else

Austin Arbor · Answer 21 · Thu Oct 28 2021 09:20:49 GMT+0800 (China Standard Time)

Oh ok, I wasn't sure if it was fixed because of these comments

#279 (comment)

I am on Spring 2.5.x so I will give latest version a try

Suresh Kumar Choudhary · Answer 22 · Fri May 27 2022 16:53:17 GMT+0800 (China Standard Time)

downgraded to 0.9.11 and worked for me. For me issue was only when i was running as docker container.

Vadim Shaigorodskiy · Answer 23 · Wed Oct 19 2022 04:14:18 GMT+0800 (China Standard Time)

I have checked different versions of Spring and I can confirm what @bmaehr already mentioned. The library throws this exception when it is used with spring-boot of version 2.3.5 or earlier. Switching to 2.3.6 solves the issue.
With the latest spring-boot version 2.7.4 it also works.

Spring framework ticket related to this issue: spring-projects/spring-boot#23821