HTML Output
bkamins opened this issue · comments
@ronisbr consider this example:
Note that we omit printing row 14 but replace it with vertical dots. So equally well we could have just printed it.
Reproducer is in https://github.com/bkamins/DataFrames-Showcase, file bison.ipynb
Yes, this is a bug. I probably used a < instead of a <= somewhere. I will investigate.
Hi @bkamins !
I do not know what to do here. You are asking in this example to show 25 data rows. Hence, PrettyTables is showing 25 data rows, but it needs 1 additional row to add the continuation line. If we modify this behavior, it might be a little confusing, because you will ask it to show 25 data rows, but 26 will be printed.
Like here:
My suggestion is:
Since this will require modify the behavior of max_num_of_rows in a way it might be confusing, if you want, we can fix this inside DataFrames. If the number of hidden rows is 1, we just show everything.
We can drop this requirement. My understanding of:
The maximum number of table rows that will be rendered.
was that it included the continuation line. However, I understand that you want not to count continuation line. In which case the current behavior is correct.
I am OK with whatever decision you make (if you want to keep things as is please close this issue)
Perfect! Let's close it here. Let me know if you want to modify the behavior in DataFrames!
Let us leave it consistent. So nothing to do. Thank you!