Question on code comment: 'This loop will terminate when the queue is empty.'
conradlo opened this issue · comments
Thanks so much for this simple example!
It really revealed the 'magic' behind javascript bundler for me.
There is a point I'm not quite understand though.
Regarding the for .. of
loop in the createGraph
function
Lines 115 to 117 in ce3b1b5
To my understanding, the loop will terminate when
- there are no more
child
asset being pushed to the end ofquery
- the code reached the end of
query
which also means the the dependency graph was completed.
Hence the query
will never be empty (there is at least one asset: the entry/main asset)
Or did I misunderstand something here?
Yes, you are totally right. The loop will only stop when it reachs the leaf of the tree, in a better scenario, it has only main.js. In the worst scenario it has to go through all the tree