Mislabeled parameter to allow logging person data.
jerryharrison opened this issue · comments
In the docs it mentions several times to add a person property to the request object. However in the code it seems only rollbar_person is being respected. I've confirmed this over hours of debugging the library and then digging through the library to note the use of rollbar_person vs person
docs:
https://docs.rollbar.com/docs/person-tracking
https://docs.rollbar.com/docs/nodejs#section-person-tracking
code:
rollbar.js/src/server/transforms.js
Line 144 in a9c567c
Ok. I feel dumb. I think all that needs to happen is update the node.js example on this doc: https://docs.rollbar.com/docs/person-tracking
The node.js specific doc https://docs.rollbar.com/docs/nodejs#section-person-tracking does appear to mention rollbar_person. Only python example on the specific person tracking page mentions rollbar_person.
I'm going to close this since no code change needs to occur, just a documentation update.
@jerryharrison Thanks for the report, and I'll take a look at the doc. I'm reopening this until the doc issue is resolved.
https://docs.rollbar.com/docs/person-tracking has been updated.