how are you guys solving the eval issue?

Question

how are you guys solving the eval issue?

georgejecook opened this issue 6 years ago · comments

George Cook commented 6 years ago

Hi, I've been looking forward to seeing how you got around using eval with sg 1_2 flag. When will you share this?

Pavel Goldin · Answer 1 · Thu Dec 13 2018 04:58:03 GMT+0800 (China Standard Time)

i've been commenting that line out for testing ( i know it is not ideal, just thought it might help someone )

George Cook · Answer 2 · Thu Dec 13 2018 05:38:59 GMT+0800 (China Standard Time)

Ok. If it helps I wrote a preprocessor for rooibos. Go check it out on the evalerradication branch

…

On Wed, Dec 12, 2018, 3:58 PM Pavel Goldin ***@***.*** wrote: i've been commenting that line out for testing ( i know it is not ideal, just thought it might help someone ) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#32 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKIUZDiQntb_ThaC6T4cso3k9S1UHu1ks5u4W3cgaJpZM4YQ3XP> .

Pavel Goldin · Answer 3 · Thu Dec 13 2018 06:45:59 GMT+0800 (China Standard Time)

Ok. If it helps I wrote a preprocessor for rooibos. Go check it out on the evalerradication branch
…
On Wed, Dec 12, 2018, 3:58 PM Pavel Goldin @.*** wrote: i've been commenting that line out for testing ( i know it is not ideal, just thought it might help someone ) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#32 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKIUZDiQntb_ThaC6T4cso3k9S1UHu1ks5u4W3cgaJpZM4YQ3XP .

can't see that branch for some reason, can you post a link ?

Pavel Goldin · Answer 4 · Thu Dec 13 2018 06:47:23 GMT+0800 (China Standard Time)

never mind found it :) i was looking at a wrong place :)

Nghia (Nick) Nguyen · Answer 5 · Wed Jan 09 2019 08:45:10 GMT+0800 (China Standard Time)

@georgejecook @pahanishe I'm running to this Eval issue with OS version 9, sg 1_2 flag.
I can no longer execute unit test. Do we have a solution for this issue or someone is looking into it?

RokuDevTools · Answer 6 · Tue Jan 15 2019 05:49:42 GMT+0800 (China Standard Time)

@georgejecook appreciate your help with community and working on rooibos!

@georgejecook @pahanishe @ngducnghia Eval was removed, please see documentation on framework v.2.0 usage: https://github.com/rokudev/unit-testing-framework/blob/master/docs/unit-test-framework.md

@georgejecook for now, you need to add those function pointers to your tests. In feature updates, some pre/post code processing would be done.