roflmuffin / CounterStrikeSharp

CounterStrikeSharp allows you to write server plugins in C# for Counter-Strike 2/Source2/CS2

Home Page:https://docs.cssharp.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

CenterHtmlMenu Open method in a weird state.

frederikstonge opened this issue · comments

Not really an issue, but something is missing here in the new CenterHtmlMenu change to support Open method.
image

IMO, we should either remove the constructor without the BasePlugin :
image

OR, throw an exception if the BasePlugin is null to inform the user that he has used the wrong constructor :

image

I agree, I almost requested this as a CR in the PR but decided against it but I think throwing the exception makes sense