example suggestion: basic Dict usage in roc

Question

Anton-4 opened this issue 8 months ago · comments

Andrea Frigido · Answer 1 · Mon Dec 18 2023 01:47:40 GMT+0800 (China Standard Time)

Hi

I would like to contribute to this issue. My PR is here: #128

I know I should have first asked in the chat, but i wasn't sure about the result of my code.

Andrea Frigido · Answer 2 · Mon Dec 18 2023 02:08:44 GMT+0800 (China Standard Time)

I've just noticed the CI script. I'll add tests for it. Keeping the PR as a Draft, for now.

Andrea Frigido · Answer 3 · Mon Dec 18 2023 04:26:04 GMT+0800 (China Standard Time)

The PR is ready to review. Please.

Anton-4 · Answer 4 · Mon Dec 18 2023 23:10:58 GMT+0800 (China Standard Time)

Thanks @frisoft! I'll try to review today :)

Anton-4 · Answer 5 · Tue Dec 19 2023 03:58:49 GMT+0800 (China Standard Time)

I've made some changes, but it's late for me so I'm going to test and review the final code tomorrow.