Update Url.roc to not use Str.appendScalar
RMailaender opened this issue · comments
PR #6395 removed Str.appendScalar from builtins. The code should be updated to user roc-lang/unicode instead.
roc-lang/unicode does not have this function implemented yet. I'll write up a pure Roc solution for now.
I think we should just remove the need for Str.appendScalar instead of implementing it a different way.
Change percentEncode to accumulate to a List U8. Then do a single Str.fromUtf8 that crashes on failure to parse (cause that should be impossible).
Yeah, we should copy this from basic-cli but crash instead of using withDefault: roc-lang/basic-cli@6208966#diff-f2522523f2f51a7e343e40fc784e44fecce8bb276db26027f3353c63f475807bR197-R228