robotmay / hubot-outofcontext

A hubot script for repeating quotes back out of context at random times.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Quotes not removed

MrMMorris opened this issue · comments

thanks for creating this awesome script. Not sure if you are still around, but it seems that quotes aren't removed. I get 'Quote has been removed from historical records', but it looks to still be in redis.

Hi Marcus,

Never thought anyone else would find this script! Yeah I remember that
being an issue the last time I used the script too, I'll see if I can fix
it if I can find the time in the next week or so, or if you have an idea as
to the issue then I'm always happy to take a PR :D

On Thu, Jul 30, 2015 at 12:38 AM, Marcus Morris notifications@github.com
wrote:

thanks for creating this awesome script. Not sure if you are still around,
but it seems that quotes aren't removed. I get 'Quote has been removed from
historical records', but it looks to still be in redis.


Reply to this email directly or view it on GitHub
#1.

yea I can't get the shell working so i'm not able to see if this works, but I imagine you are just missing the line that deletes the quote?

something like delete robot.brain.data[user.name] after https://github.com/robotmay/hubot-outofcontext/blob/master/src/outofcontext.coffee#L26 ?

I would also be neat if you could do something like hubot ooc rm last and it would delete the last said quote, but that's just a nice to have 😀