Giters

robole / vscode-file-bunny

Perform file actions quickly with keyboard-driven file selection. 🐰

Home Page:https://marketplace.visualstudio.com/items?itemName=robole.file-bunny

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rebinding Home and End keys on install can lead to confusion

SomeoneIsWorking opened this issue · comments

commented

I was wondering why my Home and End keys were acting strange all of the sudden and I thought a modifier key was stuck or something but it was because this extension changed the bindings for them.

commented

Hi @SomeoneIsWorking ,

Thanks for the feedback. What behavior do you expect for the home key?

The keybindings are documented in the README. Using home and end for navigating to the top and end of pages is common to browsers and text editors, this is why I included it.

Here is a list of the keybindings for the home key:

Kazam_screenshot_00004

The only overlap I see is with the cursorHome command. It appears that this command jumps the cursor to the beginning of the line. Is that the keybinding you use already?

With keybindings it is a matter of preference whether you like them or not. I prefer to leave it up to users to make their own keybindings for the vast majority of cases. In this case, I chose it because it is such a common keybinding across applications.

There are 3 courses of action here:

  1. Leave as it is. If you or someone else doesn't like the keybinding, just remove it through the UI given from the Preferences: Open Keyboard Shortcuts command.
  2. Remove the keybinding from the extension. This may confuse existing users.
  3. Change the keybinding to something else in the extension. This may confuse existing users. Are there more suitable keybindings to use?

I would lean towards number 1 to not disrupt other people.

commented

What behavior do you expect for the home key?

Home key in VSCode without any remappings (and many other text editors such as Notepad++) moves the cursor to start of the text in the line (after whitespace), pressing it again moves it to start of the line (before whitespace) and CTRL+Home moves it to the start of the file.
When I installed this extension and didn't notice the remapping then noticed a day after that Home key was behaving differently, I was concerned something happened to my keyboard and it didn't occur to me that an extension changed the key bindings.

The only overlap I see is with the cursorHome command. It appears that this command jumps the cursor to the beginning of the line. Is that the keybinding you use already?

Yes

There are 3 courses of action here

IMO the solution would be if this extension offered a keybinding option but doesn't rebind your keys automatically ESPECIALLY when it comes to commonly used default keybindings.

Not that it affects me in any way since I already figured out why my keys were acting strange. I only created issue to bring out the case that this may/will happen to other people who install this.

commented

Keybindings have been removed in v1.3.2.