Allow different fill color to spark line color

Question

Allow different fill color to spark line color

RichyHBM opened this issue 7 years ago · comments

As title suggests, it should be possible to get the fill drawing with a different color to the main line.

I have managed to get this working locally, with a subclass of spark view, and wondered if it would be worth porting it back into Spark and submitting a PR?

Dan Hill · Answer 1 · Sat Dec 16 2017 01:51:38 GMT+0800 (China Standard Time)

Sure! As long as it works backwards compatibly with the current fill feature, this sounds good!

Richy HBM · Answer 2 · Sat Dec 16 2017 02:14:10 GMT+0800 (China Standard Time)

Cool. Whilst doing this work I also found it quite hard to have a subclass of SparkView because a lot of the things that I needed were marked as private, so if you think its OK I may also submit another PR with some things changed to protected?