robhagemans / monobit

Tools for working with monochrome bitmap fonts

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

BDF export does not work

trevorld opened this issue · comments

I'm observing that conversion to the bdf format currently does not work. Here is a minimal, reproducible example:

$ wget https://github.com/fcambus/spleen/raw/master/spleen-6x12.bdf &> /dev/null
$ python3 convert.py spleen-6x12.bdf spleen.yaff &> /dev/null
$ python3 convert.py spleen.yaff spleen.bdf
ERROR: 'get-ordinal'

The error is thrown at line 478 of bdf.py:

        xlfd_props['DEFAULT_CHAR'] = font.get_ordinal(font.default_char)

Note the Font class defined in font.py does not define a get_ordinal() method but I'm not sure how to fix it.

Hi, thanks for reporting! Unfortunately all the code in this repo is very buggy and not ready for prime time, most of all needs a testing suite to stabilise it a bit...

Hi, I've pushed a fix for this issue, note that there are still much wider unfixed problems but the BDF conversion works again.

Thanks!