package:jsonlite used in devtools_substitutes.R but not in Imports or Suggests

Question

package:jsonlite used in devtools_substitutes.R but not in Imports or Suggests

russellpierce opened this issue 7 years ago · comments

As the title says... is this okay? It seems to annoy CMD CHECK.

Peter Wildeford · Answer 1 · Mon Nov 13 2017 12:58:20 GMT+0800 (China Standard Time)

I think it's "okay" as in the package will still be functional, but it is not desirable from stability and maintainability standpoints. We should fix it.

Russell S. Pierce · Answer 2 · Mon Nov 13 2017 22:11:35 GMT+0800 (China Standard Time)

Alright. Sounds good. jsonlite doesn't look too add any upstream dependencies so it shouldn't be a big deal. https://github.com/jeroen/jsonlite/blob/master/DESCRIPTION I'll probably be poking around in this codebase later this week. If nobody else jumps on it, then I'll fix it.

Robert Krzyzanowski · Answer 3 · Tue Nov 14 2017 00:47:22 GMT+0800 (China Standard Time)

Thanks @russellpierce , good point. Fixed here. Feel free to re-open the issue if R CMD CHECK isn't happy.