vscode-icons / vscode-icons

Icons for Visual Studio Code

Home Page:https://marketplace.visualstudio.com/items?itemName=vscode-icons-team.vscode-icons

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

file extensions not working

rickmed opened this issue Β· comments

vscode 1.4
win 10 x64

I have this

    // Configure file associations to languages (e.g. "*.extension": "html"). These have precedence over the default associations of the languages installed.
    "files.associations": {
        "*.js?": "javascript",
        "*.es": "javascript"
    },

    "vsicons.useFileAssociations": true,

Actual behaviour:
only .js files are "iconized"

image

Can confirm it.
This does not work. (I just don't recognized.)
http://prntscr.com/c26rpi

VSCode 1.4 Stable.
Windows 10 64x

(Disable and Re-Enable it does not help.)

My bad... First of all, no regular expression or glob patterns are supported. Second, I didn't really think about file associations already having its own convention (they use "javascript" instead of "js" for associations) so this won't work. I will fix it asap and let you know 😞 The only way for this to work at the moment would be this:

"*.es": "js"

But as I said, wait for the fix. πŸ˜‰

I've just published 1.5.6 that will fix this. Still not supporting complex patterns but will cover the most common scenarios.

To use it, you won't be using file.associations anymore but a custom property inside vsicons:

{
  "vsicons": {
     "useFileAssociations": true,
      "associations":{
        "*.cc": "css"
      }
    }
}

In your case, first case is not supported at the moment, but I will try to implement it if possible πŸ˜‰

@robertohuertasm updated but does not seem to be working for me.

in user settings.json

// VS Icons

  "vsicons": {
     "useFileAssociations": true,
      "associations":{
        "*.es": "js"
      }
    }

the options does not appear on the workspace settings (not sure if relevant)

same environment as above

You're right, now only supported extensions will work... . es is not in the list of supported extensions so it won't be considered.

I'll try to fix it tonight. Sorry for the inconveniences!

It's already fixed. #152
Will be released soon in a major version with other enhancements.

@robertohuertasm great work, thanks!

Already released in 1.6.0

@robertohuertasm does not work for me. Same config as above (also tried several extensions values

Please, read the new readme as this has changed to support regular expressions.

@robertohuertasm Tried a bunch of configs until I hit the update command πŸ˜…

@rickmed thanks for your feedback. I'll update the readme to make it more explicit.