Please release a new version based on master branch
Germey opened this issue · comments
Please release a new version based on master branch.
I'm developing a package based on Scrapy-Redis, but the newest release version is not same as the master branch.
For example, in scheduler.py:
self.df = load_object(self.dupefilter_cls).from_spider(spider)
The newest release version is not implemented as this, so I must change the source code and override it. But if based on master branch, it won't be changed.
Please release a new version based on master branch, thanks.
Also I'm glad to help maintaining this package, thanks~
hey @Germey, thanks for the initiative. I just invited you as collaborator.
The following days I can take a look at what is needed to streamline the process of releasing for collaborators. Meanwhile you can let me know what updates would make sense for you (i.e.: on top of my head, updating tests to run on py36-38 as well as docs).
@rmax Sorry for missing this reply, I find the invitation is expired. Count you please invite me again?
If you have more plans for the processing of releasing for collaborators, please let me know anytime.
And I also want to add support for stat based on Redis, so all the stat are synced among all the spiders. Just like this issue #46 mentioned. Wonder if you think it is make sense for you.
Hey! Thanks for the stats collector, that's really cool feature.
I will send you the collaborator invite tomorrow.
@rmax Thanks for your invitation, I've joined as a collaborator. BTW, do I have permission to publish a new release now? Do you need to add permission for me on PyPi?
Also for my contribution yesterday, thanks for your merging. But there are a bug with redis 3.x, I've send another PR to fix a issue on redis 3.x, pls help to review it, thanks #187
Could you register to pypi.org and let me know your username?
@rmax My username is Germey, here is my home link of PyPi: https://pypi.org/user/Germey/
Thanks~
@Germey added you as maintainer on pypi 🚀
@Germey feel free to go ahead and release a new version, procedure is bumpversion based, see here https://github.com/rmax/scrapy-redis/blob/master/Makefile#L119-L124
then make dist-upload https://github.com/rmax/scrapy-redis/blob/master/Makefile#L126-L127 which uses twine
Fair warning, this procedure haven't been updated in years 🙈 😅