"TypeError: null is not an object" error when browser popups are blocked
blutter opened this issue · comments
The error "TypeError: null is not an object" will appear when browser popups are blocked and the NewWindow component is rendered.
This error started occurring in v0.1.3 and appears to be caused by the changes in 1eeae9b
Specifically the change:
this.window = window.open(url, name, toWindowFeatures(features))
-
+ this.container = this.window.document.createElement('div')
When blockups are blocked then window.open() returns null.
A workaround is to downgrade to v0.1.2
Thanks for the report. I will check that soon.
…On Tue, Mar 30, 2021, 23:12 Benjamin Tse ***@***.***> wrote:
The error "TypeError: null is not an object" will appear when browser
popups are blocked and the NewWindow component is rendered.
This error started occurring in v0.1.3 and appears to be caused by the
changes in 1eeae9b
<1eeae9b>
Specifically the change:
this.window = window.open(url, name, toWindowFeatures(features))
-
+ this.container = this.window.document.createElement('div')
When blockups are blocked then window.open returns null
<https://developer.mozilla.org/en-US/docs/Web/API/Window/open#return_value>
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#79>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADLMH6REVRBFZETKHS3GULTGKHJHANCNFSM42DRCIKQ>
.
Hi! I have the same problem, is this resolved?