Can't get subfolder messages

Question

Can't get subfolder messages

Daviex opened this issue 7 years ago · comments

Hello.

I'm trying to get some languages texts from a subfolder.
The result message.js is creating the file correctly with the following code:

(function () {
    Lang = new Lang();
    Lang.setMessages({"en.javascript.datatables":{"emptyTable":"No data available in table"},"it.javascript.datatables":{"emptyTable":"Alcun dato disponibile"}});
})();

I checked over chrome console, and Lang has locale set to "it", so, I tried to do

Lang.get('javascript.datatables.emptyTable');

but it can't find nothing, in fact that string returns the pattern I wrote.
I'm executing wrongly the query for that string?

I also tried with a non subfolder file, and that worked perfectly...

Thanks

Rubens Mariuzzo · Answer 1 · Fri May 19 2017 22:09:49 GMT+0800 (China Standard Time)

Hey @Daviex! Thanks for filing an issue I will check that issue later on the weekend, as I'm pretty busy with work and the ongoing ReactEurope event.

Davide Iuffrida · Answer 2 · Fri May 19 2017 22:19:44 GMT+0800 (China Standard Time)

Ok @rmariuzzo, thank you. For now I resolved my problem by putting a main file into the lang folder and setting all the texts in there with sub keys, but I would like to use folders 😄

ps. Awesome library man 🔝

Davide Iuffrida · Answer 3 · Mon May 22 2017 21:22:57 GMT+0800 (China Standard Time)

Hey @rmariuzzo, did you had anytime to check over this thing?

Thanks

Davide Iuffrida · Answer 4 · Tue Jul 11 2017 16:22:32 GMT+0800 (China Standard Time)

Hey man, did you had time to get a look at this?

Thanks

Rubens Mariuzzo · Answer 5 · Tue Jul 11 2017 20:18:44 GMT+0800 (China Standard Time)

Not really, it would be of great help to receive a PR. Will try to check this over this weekend.

…

On Jul 11, 2017 04:22, "Davide Iuffrida" ***@***.***> wrote: Hey man, did you had time to get a look at this? Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#100 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa2H8ecUPr3YlcW0hTG8q8HxhWMpgVjks5sMzDJgaJpZM4Ngkbb> .

Davide Iuffrida · Answer 6 · Tue Jul 11 2017 21:21:19 GMT+0800 (China Standard Time)

Ok thanks.

I tried to look over it, but really cound't find how to make it happen.

Rubens Mariuzzo · Answer 7 · Wed Jul 12 2017 02:54:59 GMT+0800 (China Standard Time)

Thanks for your effort. I will have a look very this weekend.

…

On Jul 11, 2017 09:21, "Davide Iuffrida" ***@***.***> wrote: Ok thanks. I tried to look over it, but really cound't find how to make it happen. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#100 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa2H1TQ2-JG5fpaa8lF36D7xklr73UIks5sM3bPgaJpZM4Ngkbb> .

Frano Sasvari · Answer 8 · Sat Sep 16 2017 18:12:30 GMT+0800 (China Standard Time)

Any progress on this question ? It would be very nice to put JS translation in separate folder. In localization-hr.php configuration file I have following messages array:

 'messages' => [
    'js/config',
    'js/message',
    'js/page',
    'js/routes',
],

Tried Lang.get('js.config.key');, Lang.get('js/config.key'); and Lang.get('js:config.key'); but none works.

Thanks in advance and very nice package ;)

Rubens Mariuzzo · Answer 9 · Sat Sep 16 2017 23:23:43 GMT+0800 (China Standard Time)

Thanks for adding more details and bumping this issue. I will put it on the list forget next release.

…

On Sep 16, 2017 06:12, "Frano Sasvari" ***@***.***> wrote: Any progress on this question ? It would be very nice to put JS translation in separate folder. In localization-hr.php configuration file I have following messages array: 'messages' => [ 'js/config', 'js/message', 'js/page', 'js/routes', ], Tried Lang.get('js.config.key');, Lang.get('js/config.key'); and Lang.get('js:config.key'); but none works. Thanks in advance and very nice package ;) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#100 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa2H68UqFvGbOuu5MRaqespyelzCY9Oks5si58OgaJpZM4Ngkbb> .

Davide Iuffrida · Answer 10 · Thu Sep 21 2017 16:49:13 GMT+0800 (China Standard Time)

Thanks.

Hopes you can find a solution over this, for the time passed I used just a file in the root of the language folder, but a solution would be awesome :)

Frano Sasvari · Answer 11 · Thu Sep 21 2017 16:53:20 GMT+0800 (China Standard Time)

Another "hacky" solution to this is to create folder "lang-js" in "resources" folder.

And then when running npm and webpack mix, you can set source path:

const WebpackShellPlugin = require('webpack-shell-plugin');

mix.webpackConfig({
    plugins: [
        new WebpackShellPlugin({onBuildStart:['php artisan lang:js -c -s resources/lang-js'], onBuildEnd:[]})
    ]
});

Rubens Mariuzzo · Answer 12 · Thu Oct 05 2017 01:53:47 GMT+0800 (China Standard Time)

I'm really sorry for the long wait. I'm still trying to balance my life after Hodgkin. From the original poster, I was able to get the expected message using:

Lang.get('javascript/datatables.emptyTable') // using `/` instead.

That's how it works on Laravel, therefore this work on Lang.js.

However, I will add a test for the / case into Lang.js repository.