Giters

ritterim / platform-ui

A CSS framework build all of our apps and websites.

Home Page:https://platformui.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove `pui-` prefix

tedk13 opened this issue · comments

commented

💰 Refactor

Remove pui- prefix from components. SCSS/JS

Benefits of refactor

Reduced file size and update code.

Estimates

FE - 3

commented

this would go to npm as a patch

commented

Guessing since this is still in Working that there may be more? Just wanted to call out a few more places that need to be addressed.

  • submission-form
    • Medicareful (the Enrollment page/submission-form runs on pui - we'll need to ensure that there are no visual changes that would require a refile)
  • OQE (I think it may already be done here but please double check!)
commented

Discussed this with @tedk13 and we decided that any repo that is behind the BEM update of 1.3.0 is not worth updating in this issue and is scope creep. We need to set up an issue in each repo to update platform-ui to the latest version. The last repo we wanted to update to 1.5.1 was docs and Ryan's PR takes care of that.

commented

We may want to revert this in Platform or add a plugin that still supports some pui- prefixes then. submission-form has a few in there and is utilized in both Medicareful and Platform. The styling around the MC style eligibility that agents will see has broken with this change.

Give me a few and I can update this comment with a list of the classes that are using it.

commented

I propose a plugin

commented

@jaime-lynn and I reviewed this; Let's proceed as follows:

  1. Remove all pui- prefixes from submission form; the Ritter Platform shouldn't notice the change.
  2. Wrap _rim-submission-form.scss in rim-submission-form {...} and remove pui- prefixes there as well.
  3. Coordinate Submission form version advancing with this change in both MC and platform.

One of the biggest changes was rounded corners on cards and messages. So they may need an additional border-radius: 0; added.

cc/ @Boltz23

commented

Austin is the one currently working on this issue but I don't understand 2 and 3

commented

I also don't understand 2 and 3

commented

Apologies; 2 and 3 relate to the impact, via submission form, on Medicareful.
I can add supporting issues in Medicareful as blocking this issue.

commented

Blocking issues have been added here; submissions form and medicareful.
If anyone is needs additional clarity, please reach out directly.

commented

The location that needs to be QA'd in this issue is the submission-form in the Platform. No visual updates should have been made as we were just removing the prefix pui- without changing any of the css. If anything looks out of place, let me know!

commented

Submission form in the Platform checks out.