modify meta node bootstrap parameters
mikechesterwang opened this issue · comments
Due to risingwavelabs/risingwave#7527, the operator need to change the parameters of the meta node.
Error occurs in meta node when creating nightly-built (nightly-20220130) instance:
launching meta node
error: Found argument '--host' which wasn't expected, or isn't valid in this context
If you tried to supply `--host` as a value rather than a flag, use `-- --host`
USAGE:
meta-node --config-path <CONFIG_PATH> --listen-addr <LISTEN_ADDR>
For more information try --help
At the time of speaking, the latest release v0.1.16 doesn't include these arguments. So I think currently we should not do the change which will break all the released versions. But as discussed in risingwavelabs/risingwave#7530 (comment), the arguments should coexist in at least one version. That is said, the v0.1.17 will support them while maintaining compatibility. At that time, we can use the new arguments and announce the new minimum supported version.
cc. @mikechesterwang @lmatz @jon-chuang for awareness.
I think it should be fixed for the time being. We already applied the fixes for backwards compatibility.
@jon-chuang yes, absolutely. I wanted to say that the fixes are not included in the recent release, so it's not a good time to change the operator because no released version can be deployed after the change. We'll need a version that supports the old and new arguments to ensure the operator can always work on at least one released RisingWave version.
At that time, we can use the new arguments and announce the new minimum supported version.
+1,
risingwavelabs/risingwave#7732
we will retire the old arguments in v0.1.18.
So v0.1.17 will be a version that
supports the old and new arguments
to ensure the operator can always work on at least one released RisingWave version.
As planned, the v0.1.17's been released. Will support it soon.