rishikksh20 / Fre-GAN-pytorch

Fre-GAN: Adversarial Frequency-consistent Audio Synthesis

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

do nn upsample before mel condition

liuhuang31 opened this issue · comments

for generator code line 137:

if i >= self.cond_level: 
                mel = self.cond_up[i - self.cond_level](mel)
                x += mel
if i > self.cond_level:
    if output is None:
        output = self.res_output[i - self.cond_level - 1](x)
    else:
        output = self.res_output[i - self.cond_level - 1](output)

in the code, for the nn upsample input is: mel condition + resblock output.

image

but in the paper, nn upsample input only is resblock output or the last nn upsample output;

image

so, Is this more reasonable?

if i > self.cond_level:
    if output is None:
        output = self.res_output[i - self.cond_level - 1](x)
    else:
        output = self.res_output[i - self.cond_level - 1](output)
if i >= self.cond_level: 
                mel = self.cond_up[i - self.cond_level](mel)
                x += mel