Nitro Banners not animating

Question

Nitro Banners not animating

remy010 opened this issue 9 months ago · comments

Hello Admin, can you fix this issue? The issue is that when I toggle on the plugin, I can't see other people's banners moving means that they are using Discord Nitro and putting in a GIF in their banners but when I toggle it off, the GIF banners are moving perfectly fine.

Can you fix it please?

riolubruh commented 9 months ago

Confirmed

riolubruh · Answer 1 · Thu Nov 02 2023 06:17:53 GMT+0800 (China Standard Time)

Oh this is ironic, hahaha. The issue is caused because the original function returns a png instead of a gif for some reason.

riolubruh · Answer 2 · Thu Nov 02 2023 06:46:20 GMT+0800 (China Standard Time)

Figured it out. For some unknown reason, the function getUserBannerURL wasn't receiving the 'canAnimate' argument, so it was assuming that it couldn't!
Overriding it as below fixes the issue:

However, as a side effect, nitro banners will continue animating even if the window is not focused (which i think literally nobody would care about or even notice tbh)

Remy10 · Answer 3 · Thu Nov 02 2023 23:03:11 GMT+0800 (China Standard Time)

Figured it out. For some unknown reason, the function getUserBannerURL wasn't receiving the 'canAnimate' argument, so it was assuming that it couldn't! Overriding it as below fixes the issue: However, as a side effect, nitro banners will continue animating even if the window is not focused (which i think literally nobody would care about or even notice tbh)

so that's means you can't fix it? It's a bug feature?

riolubruh · Answer 4 · Thu Nov 02 2023 23:14:42 GMT+0800 (China Standard Time)

As I said, the issue can be fixed, there's just a minor side effect to the fix.