rimusz / charts

Helm Charts for Kubernetes

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

gcloud-sqlproxy: Support for alpine based container image for livenessProbe ?

prakharrr-sl opened this issue · comments

Is this a request for help?:

Yes

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Feature Request

** If this is a FEATURE REQUEST, please:

  • Describe in detail the feature/behavior/change you'd like to see.
    I'm using sqlproxy chart and wanted to setup a health check or maybe a serviceMonitor

Version of Helm and Kubernetes:
Kubernetes: 1.17
Helm: 3.2.4

Which chart:
gcloud-sqlproxy 0.19.13

What happened:
Is there a workaround to use a different image that has nc installed.
I enabled livenessProbe and defined the port as 3306

livenessProbe:
  exec:
    command: ["nc", "-z", "127.0.0.1", "3306"]

What you expected to happen:
I did read that as of v1.16 and above cloudsql proxy container is based on distroless and there are a couple of alternatives mentioned here https://github.com/GoogleCloudPlatform/cloudsql-proxy#container-images

The version of the chart I'm using is 0.19.13. So if I were to set the image tag in my values to this:

image: gcr.io/cloudsql-docker/gce-proxy-alpine
imageTag: "1.16"

Would it have any breaking changes ?

How to reproduce it (as minimally and precisely as possible):
define livenessProbe with exec

livenessProbe:
  exec:
    command: ["nc", "-z", "127.0.0.1", "3306"]
  enabled: true
  port: 3306

I'm not using this chart myself anymore, only keeping and maintaining it for the community, which does the changes they need.
So I cannot answer your question if we can use alpine image, just make those changes and test it.