SpringJUnitControllerTest is not using Junit 5
madmas opened this issue Β· comments
ππ₯ First Timers Only
This issue is reserved for people who never contributed to Rico or Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you π
πΎ Description of the issue
After #79 and the update to recent spring versions, The class SpringJUnitControllerTest
should be base on JUnit 5.
π Step by Step
To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here.
- Claim this issue: Comment below.
- Fork the repository in github by simply clicking the 'fork' button.
- Check out the forked repository
- Create a feature branch for the issue. We do not have any naming definition for branches, but it doesn't hurt if it contains the issue number.
- Commit your changes.
- Start a Pull Request.
- Done π Ask in comments for a review :)
- If the reviewer find some missing pieces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
- You did it π We will merge the fix in the master branch.
- Thanks, thanks, thanks for being part of this project as an open source contributor β€οΈ
π Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a change to receive cool goodies like a T-Shirt. π½
π€β Questions
If you have any questions just ask us directly in this issue by adding a comment. Next to this you can find a general manual about open source contributions here.
I would like to work on this issue. Please assign it to me.
@rubyAnneB here you go, it's now assigned to you :) - but just claiming it with a comment would also be fine! have fun!
I've submitted a pull request. Please review it.