Bad code generated
adamf663 opened this issue · comments
Tried plugin; it generates some bad code.
- clickl method out of nowhere followed by invalid java code.
/**
* Submit the form to target page.
*
* @return the GoogleHomePage class instance.
*/
public GoogleHomePage submit() {
clickI'mFeelingLuckyButton();
return this;
} - WebDriverWait, ExpectedCondition
If necessary I can post the code, or you can simply go to google.com and run the plugin to generate a java page object model class.
Good catch, Adam. Should be fixed in version 1.2.5. Please reopen otherwise.
Also: it doesn't handle tables properly. It generated a separate element/click/set for every cell.
No biggie; I'll hand edit to handle such cases.
It's a great tool and I expect it to be a tremendous time saver.
----- Original Message -----
From: "Richard Huang" notifications@github.com
To: "rickypc/selenium-page-object-generator" selenium-page-object-generator@noreply.github.com
Cc: "adamf663" adam.github@thefelsons.us
Sent: Tuesday, September 22, 2015 9:45:39 PM
Subject: Re: [selenium-page-object-generator] Bad code generated (#3)Closed #3.
Reply to this email directly or view it on GitHub:
#3 (comment)