ricktu288 / ray-optics

A web app for creating and simulating 2D geometric optical scenes, with a gallery of (interactive) demos.

Home Page:https://phydemo.app/ray-optics/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Adding Bandwidth to Mirror Dichroic Feature

gljames24 opened this issue · comments

I realized, after doing additional research into optics, that the "dichroic feature" actually referred to as a narrow bandpass filter and that there are several optical devices including bandpass, notch, longpass, and shortpass filters as seen here:
image
image
image

This is why I added a bandwidth slider that lets users easily cover whole sections of the spectrum to easily create these filters. I have already added the feature on my own fork, and I wanted to know if you would like to add it as a feature to the main project.

I don't have a translation for bandwidth yet. I am also unsure if you would want the bandwidth to be ± a value or the full width. I went with ± as it seemed more intuitive for me. Let me know if there are any errors or changes you want me to make with this code if you want to add it to the project.

Here's a photo of the feature in use:
image

I added locale definitions and submitted a pull request #100.