Test relies on specific output from sample_islands() for given seed
szhorvat opened this issue · comments
The "counting the number of strongly connected components is possible" test currently relies on igraph's sample_islands() function returning a specific output for a specific seed.
https://github.com/rich-iannone/DiagrammeR/blob/main/tests/testthat/test-count_entities.R#L129
We do not guarantee that the output of such stochastic functions won't change across versions (for the same seed). Can you please refactor the test not to rely on this? In an upcoming version of igraph, sample_islands() will change, causing this test to fail.
On a related note, the title of this test mentions "strongly connected components", but the test is executed for an undirected graph, which doesn't look right.
@rich-iannone: We're releasing igraph 2.0.0 just before CRAN closes for Christmas. Tracking issue: igraph/rigraph#989.
New anticipated release data: January 12.
We're planning to send igraph to CRAN on January 23, we're still seeing failures with this package: https://github.com/igraph/rigraph/blob/main/revdep/problems.md .