Setting to only convert Hamcrest, but not JUnit assertions?
soc opened this issue · comments
I had a look at the plugin page, but couldn't find any settings.
Is this something that could be made possible?
The plugin should be converting most Junit assertions. Could you provide an
example file where Junit assertions are not being converted?
Thanks
…On Thu, Mar 4, 2021 at 3:53 AM soc ***@***.***> wrote:
I had a look at the plugin page, but couldn't find any settings.
Is this something that could be made possible?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALYOG4EWY4ZXJUFGI32IJLTB5RD3ANCNFSM4YTAOJBQ>
.
Hi Rice,
my comment was probably not clear – I was wondering whether it is possible to configure it to only convert Hamcrest assertions, but to leave JUnit asserts alone. (Basically only convert assertThat.)
Cheers,
Simon
(Completely unrelated: IntelliJ reported two exceptions in your plugin – are you interested in the stacktraces?)
Oh, I am sorry for the confusion.
There is not a way to disable Junit assertion conversion. The only solution
I could suggest would be to download the plugin source code, comment out
the Junit converter and recompile the modified source.
…On Thu, Mar 4, 2021 at 6:58 AM soc ***@***.***> wrote:
Hi Rice,
my comment was probably not clear – I was wondering whether it is possible
to configure it to only convert Hamcrest assertions, but to leave JUnit
asserts alone.
Cheers,
Simon
------------------------------
(Completely unrelated: IntelliJ reported two exceptions in your plugin –
are you interested in the stacktraces?)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALYOG2YSMA6JWY3LBE2KWTTB6GWVANCNFSM4YTAOJBQ>
.
Ok, thanks! Would you a PR be welcome, if I manage to find the time to look into the source?
Yes! PRs are welcome.
…On Thu, Mar 4, 2021 at 7:08 AM soc ***@***.***> wrote:
Ok, thanks! Would you a PR be welcome, if I manage to find the time to
look into the source?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALYOG7HPZB5QKA5T776KUTTB6H6JANCNFSM4YTAOJBQ>
.
Cool, thanks!
I am not sure how to pass the option to the plugin to only convert a single
Assertion type. But, I can explain how the code currently works.
There are three different classes that determine which file or files get
converted
* ProjectAction gets called when the user wants to convert all files in a
project
* ModuleAction gets called when the user wants to convert all the files
from a single module
* FileAction gets called when the user wants to convert a single file
The FileHandler class gets called to convert each file. The FileHandler
class holds onto a list of converter classes to call to attempt conversion
of a statement. Somehow you would need to pass a flag into the FileHandler
class to tell the class which converters to invoke. This part won't be
difficult.
The code is at - https://github.com/ricemery/Assertions2AssertJ
…On Thu, Mar 4, 2021 at 7:12 AM soc ***@***.***> wrote:
Cool, thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALYOG3BVWR43M6Z2M47J23TB6IOXANCNFSM4YTAOJBQ>
.
Thanks for the hints!
I agree, I think the hardest part is figuring out how to create a settings page for the plugin, add some checkboxes to it, and wire them up.