Incorrect logic for `if` for `success() || failure()`

[Andrew Vaughan]

if: condition "${{ success() }} || ${{ failure() }}" is always evaluated to true because extra characters are around ${{ }} [if-cond]
    |
184 |         if: ${{ success() }} || ${{ failure() }}
    |             ^~~

I don't believe this is correct - if a workflow is canceled, this will not evaluate to true.

[Andrew Vaughan]

Note that this causes all megalinter configurations to fail currently.

[ChristopherHX]

I don't believe that your statement is correct, just tested this scenario and the job run after a the workflow has been cancelled. Even while it should be skipped.

if: ${{ success() }} || ${{ failure() }}

Also known as

if: ${{ format('{0} || {1}', success(), failure()) }}

Is always a non empty string, non empty strings are truthy.

Due to the usage of success and failure you don't get success() && (yourcond) applied.

There is no evidence that GitHub tried to fix this

Good ways to write the intended meaning is to use one of

# ok no implicit format to merge multiple scalar expressions
if: ${{ success() || failure() }}
# ok no expression notation, implicit expression
if: success() || failure()

[ChristopherHX]

Here is the relevant source code of the actions/runner template engine:

https://github.com/actions/runner/blob/9e3e57ff90c089641a3a5833c2211841da1a37f8/src/Sdk/DTObjectTemplating/ObjectTemplating/TemplateReader.cs#L589-L619'

Single vs. multiple Segments of ${{ }} are relevant for this GitHub Actions Bug.