Update to Node 10
rdebeasi opened this issue · comments
jenkins-slave-npm is currently at version 8, but the latest Node.js LTS version is 10. v10 is available in OpenShift - see centos7-s2i-nodejs.
Could we update to version 10 of jenkins-slave-npm? Thanks! 😄
CC @cognizen, who is looking to use npm v6 in pipelines. Node 8 is compatible with npm 6, but it seems like the cleanest way to update npm is probably to update the entire build slave.
let's try to stick to product versions if we can @rdebeasi . Latest product versions are node.js 8. I suspect OCP 4 will ship node 10.
https://access.redhat.com/containers/?tab=overview#/registry.access.redhat.com/rhscl/nodejs-8-rhel7
ahhh I stand corrected. we now have two node.js distros sigh....
Looks like runtime supports 10 https://access.redhat.com/containers/?tab=overview#/registry.access.redhat.com/rhoar-nodejs/nodejs-10, but jenkins does not yet.
Gotcha - thanks for clearing that up! Is that something that could get updated in jenkins-slave-npm, or would we need to wait for OCP 4?
I added you to a thread internally on this for context Ryan.
In short, it looks like updating CoP repos to run node 10 is the right approach. Yes we can do that, some one just needs to open an issue / PR over there.
Awesome, thanks! Issue opened: redhat-cop/containers-quickstarts#181
Looks like this change has been made upstream. Node 10 should be included in the next release of containers-quickstarts.
Didn't I already do this? IIRC, I created a NodeJS 10/NPM 6+ container image based on what we created at DHS...
Thanks for calling that out! Yep, looks like that PR does include NodeJS 10 along with a some new security features. Feedback was submitted three weeks ago, and the PR is pending updates based on that feedback. Looking forward to seeing some npm audit coolness in there! 😄
The good news is that containers-quickstarts now includes Node 10 in master, and the changes that @pabrahamsson made should apply cleanly over yours.
The only remaining work in this labs-ci-cd issue is to wait for a new release of containers-quickstarts and bump the version number accordingly.
Those requested changes were merged and submitted.
https://github.com/redhat-cop/containers-quickstarts/tree/v1.7 now has this merged and tagged.
Looks like we're now pointing to containers-quickstarts 1.9, which includes Node 10. Thank you, @InfoSec812, @haithamshahin333, and @sherl0cks !!!! 😄 🚀 🍕