Friendly fork ?

Question

Friendly fork ?

bersace opened this issue 8 years ago · comments

TL;DR Go use https://github.com/jd/tenacity ! :)

Hi,

retrying is a nice piece of code, thanks to @rholder and contributors !

Sadly there is no activity since june 2016. Several contributors suggest to create a friendly fork to keep retrying alive. I'm one of them.

What do you think of this ?

cc @RyPeck @charlescbeebe @reversefold @harlowja @bodenr @robin81 @jpic @doubleloop @davidyen1124 @underrun

boden · Answer 1 · Tue Nov 22 2016 19:31:55 GMT+0800 (China Standard Time)

@bersace have a look at: https://github.com/jd/tenacity

Ryan Peck · Answer 2 · Thu Nov 24 2016 08:54:35 GMT+0800 (China Standard Time)

@bodenr @jd love the name.

Julien Danjou · Answer 3 · Thu Nov 24 2016 17:22:44 GMT+0800 (China Standard Time)

For the record, yeah, I tried to work with @rholder for a few months but I guess he's very busy. Since we did not manage to go anywhere with retrying for a long time, so I ended up forking it.

J Derek Wilson · Answer 4 · Fri Nov 25 2016 00:46:07 GMT+0800 (China Standard Time)

Can we keep a fork with the original name please? I really don't want to go back and change a bunch of code. Name change are a big deal. Also, i dont mind a fork, but it's much more polite if you actually forked something on GitHub to actually fork it on GitHub so that people can see the lineage and that it is a fork of an original repo. This looks - at best - either inept or discourteous. I'm seriously not trying to ruffle feathers here - i just think these things should be considered and we should treat people with respect even when they get busy or whatever. This is, after all, a thread about a friendly fork. Let's be friendly.

Étienne BERSAC · Answer 5 · Fri Nov 25 2016 00:48:19 GMT+0800 (China Standard Time)

I switched to tenacity. It has been nicely cleaned.

@underrun you may provide a open a PR with compatibility module in https://github.com/jd/tenacity ?

Julien Danjou · Answer 6 · Fri Nov 25 2016 01:09:39 GMT+0800 (China Standard Time)

While I understand your concern @underrun, I imagine the lack of context and information makes your comment a little bit offensive. :)

So for the record, the API is not compatible, so there's no point keeping any name. And @rholder never replied to any of my request to help maintaining this library and I've no PyPI access to upload it.

Sorin Sbarnea · Answer 7 · Thu Jan 12 2017 04:37:02 GMT+0800 (China Standard Time)

That's the sad story of many nice Python libraries that become abandonware because they had only one person behind them.

For this reason I published all Python libraries under pycontribs github team where I assured there are others that can continue improving them even without me.

Some people do think that forks are good but my view is a little bit different: they are usually a sign of something not working in the forked project. Forked projects to confuse people, not adding much to the overall user/consumer/developer experience.

It is much better when there is no need to fork, everyone working for the same goal: of having one library that really works (as opposed to having 10 blends which all partially work).

@rholder If you read this and like the idea of sharing maintenance with few other skilled Python developers, feel free to ping me. For the moment I am going to have a look at https://github.com/jd/tenacity as it seems to be better bet (actively maintained) ;)

Ondrej Medek · Answer 8 · Wed Jan 18 2017 03:35:26 GMT+0800 (China Standard Time)

@ssbarnea Another, more popular Python join effort is https://jazzband.co/

rachmadani haryono · Answer 9 · Thu Jun 22 2017 22:44:44 GMT+0800 (China Standard Time)

@jd or contributor at tenacity, will there be list abandoned/resolved issue and merged/skipped pr from this library?

because after this issue, there are #66, and #69

Étienne BERSAC · Answer 10 · Fri Nov 02 2018 16:21:20 GMT+0800 (China Standard Time)

@rholder Hi, can you state the project is unmaintained either by archiving it or adding a tag in the description ? What do you think of it ?