rgrinberg / opium

Sinatra like web toolkit for OCaml

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fullsplat discarded

reynir opened this issue · comments

I don't find much documentation on how the routes work, especially with splats (* and **).

| [], [] | [ FullSplat ], _ -> Some matches

I would expect we should add the rest of the URL path to matches.splat instead of ignoring it?

The line after has a comment that seem to me to describes exactly the opposite of what the code does :-)

| FullSplat :: _, _ -> assert false (* splat can't be last *)