Missing check for plaintextnames in many FUSE callbacks

Question

Missing check for plaintextnames in many FUSE callbacks

slackner opened this issue 7 years ago · comments

Steps to reproduce:

Create a regular GoCryptFS mount point in forward mode and with -plaintextnames
In the mount point directory try to run touch gocryptfs.longname.XXX

This fails with the error No such file or directory, but should actually succeed. The problem is that many FUSE calls do not explicitly check if plaintextnames is set.

Sebastian Lackner · Answer 1 · Mon Nov 27 2017 05:39:51 GMT+0800 (China Standard Time)

On the first sight this affects the following functions:

Sebastian Lackner · Answer 2 · Tue Nov 28 2017 17:32:13 GMT+0800 (China Standard Time)

I fear this one was closed a bit too early. Mknod and Unlink are fixed now, but there might be three other functions affected by the same problem. Should I open new bugs for them?

rfjakob · Answer 3 · Tue Nov 28 2017 17:37:06 GMT+0800 (China Standard Time)

Was auto-closed through the commit message i guess, just re-open it

…

On Nov 28, 2017 10:32, "slackner" ***@***.***> wrote: I fear this one was closed a bit too early. Mknod and Unlink are fixed now, but there might be three other functions affected by the same problem. Should I open new bugs for them? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#174 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARgf09xj-u5Cg9j2Kw71xfQOO8meFifks5s69MegaJpZM4QqRkd> .

Sebastian Lackner · Answer 4 · Tue Nov 28 2017 17:38:15 GMT+0800 (China Standard Time)

I would, but apparently I don't have permission to reopen myself.

rfjakob · Answer 5 · Tue Nov 28 2017 17:41:19 GMT+0800 (China Standard Time)

Hmm will check if i can allow that somehow