Giters

rexray / rexray

REX-Ray is a container storage orchestration engine enabling persistence for cloud native workloads

Home Page:http://rexray.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

make warnings: find -d option is deprecated, find paths must precede expression 1

diablodale opened this issue · comments

commented

In Makefile, the parameters to find cause warnings/errors of deprecated options and expression precedence. This is due to an invalid use of the -d parameter. -d is deprecated and -d doesn't take a numeric value after it. This two actions cause the warning and error seen.

rexray/Makefile

Line 383 in 3620358

GIST_FILES += $(shell find "$(GIST_DRIVER)" -d 1 -type f \

I think the intention was to use the -maxdepth parameter.

In addition, there is the possibility of an error sometime in the future by using a wildcard in the following -name. It needs to be single quoted so the shell glob doesn't expand it.

rexray/Makefile

Line 227 in 3620358

for f in $$(find libstorage -name "*.test.out" -type f); do \

Setup

Ubuntu 18.04
Docker 19.03.1 is installed
Go is not installed

Repo

  1. clone the rexray repo
  2. change pwd into the root of the repo
  3. DRIVER=ebs make

Result

find: warning: the -d option is deprecated; please use -depth instead, because the latter is a POSIX-compliant feature.
find: paths must precede expression: `1'

Expected

No warnings or errors