reviewdog / reviewdog

🐶 Automated code review tool integrated with any code analysis tools regardless of programming language

Home Page:https://medium.com/@haya14busa/reviewdog-a-code-review-dog-who-keeps-your-codebase-healthy-d957c471938b#.8xctbaw5u

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Tfsec- parse error: failed to unmarshal rdjson (DiagnosticResult): proto: syntax error (line 1:1): unexpected token

marcincuber opened this issue · comments

Started seeing issues such as:

Running tfsec with reviewdog 🐶 ...
parse error: Invalid numeric literal at line 3, column 0
reviewdog: parse error: failed to unmarshal rdjson (DiagnosticResult): proto: syntax error (line 1:1): unexpected token

I am using following workflow:

tfsec:
    name: "Aqua tfsec"
    if: github.ref != 'refs/heads/main' && github.event_name == 'pull_request'
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v4
      - name: tfsec
        id: tfsec
        uses: reviewdog/action-tfsec@master
        with:
          working_directory: aws
          tfsec_flags: "--concise-output"
          reporter: github-pr-review
          fail_on_error: true
          github_token: ${{ secrets.API_GITHUB_TOKEN }}

Can you advise if that is related to the latest 0.15 release of reviewdog and whether there is a fix to the error?

It is not an issue of reviewdog but tfsec.
see reviewdog/action-tfsec#95 and aquasecurity/tfsec#2099.

whether there is a fix to the error?

Pinning the tfsec version to v1.28.1 worked for us.

        with:
          working_directory: aws
          tfsec_version: "v1.28.1"
          tfsec_flags: "--concise-output"
          reporter: github-pr-review
          fail_on_error: true
          github_token: ${{ secrets.API_GITHUB_TOKEN }}