fail_on_error does not work for golangci-lint
ivvist opened this issue · comments
Hi,
My github action yml is simple:
name: reviewdog
on: [push, pull_request]
jobs:
golangci-lint:
runs-on: ubuntu-latest
steps:
- name: Check out code into the Go module directory
uses: actions/checkout@v2
- name: golangci-lint
uses: reviewdog/action-golangci-lint@v2
with:
fail_on_error: true
In Github actions I see the result:
But test looks as passed - it's green
I need to notify user that linter catch the error and commit is bad.
How can I make it Red?
The build log says "this is not PullRequest build".
reviewdog doesn't fail in this case.
please show me the build log on the pull_request
event.
True, this was not pull request event, that was just push.
But every time I make push I need to know all errors linter gives me as well as during pull request.